Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nit: LLVM & Clang latest version is 4.0 #40704

Merged
merged 1 commit into from
Mar 23, 2017
Merged

Nit: LLVM & Clang latest version is 4.0 #40704

merged 1 commit into from
Mar 23, 2017

Conversation

kirillbobyrev
Copy link
Contributor

Small nit: since latest Clang version is 4.0 it's nice to reflect this in the documentation.

Also, I couldn't find anything, but there might be any hard-coded check that Clang version matches "3.X" anywhere in the build system; if there is one, it'd be great to bump that one too.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 21, 2017

📌 Commit fac91c5 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Mar 21, 2017

🔒 Merge conflict

@bstrie
Copy link
Contributor

bstrie commented Mar 21, 2017

I've rebased this branch due to a submodule conflict that invalidated many PRs.

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Mar 21, 2017

📌 Commit 71020e3 has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 22, 2017
@frewsxcv
Rollup merge of rust-lang#40704 - omtcyfz:clang_version_bump, r=alexc…
f2e801e 
…richton

Nit: LLVM & Clang latest version is 4.0

Small nit: since latest Clang version is 4.0 it's nice to reflect this in the documentation.

Also, I couldn't find anything, but there might be any hard-coded check that Clang version matches "3.X" anywhere in the build system; if there is one, it'd be great to bump that one too.
@frewsxcv frewsxcv mentioned this pull request Mar 22, 2017
Merged
bors added a commit that referenced this pull request Mar 22, 2017
@bors
Auto merge of #40748 - frewsxcv:rollup, r=frewsxcv
c62e532 
Rollup of 13 pull requests

- Successful merges: #40509, #40523, #40548, #40578, #40619, #40689, #40690, #40692, #40704, #40722, #40723, #40725, #40732
- Failed merges:
@bors bors merged commit 71020e3 into rust-lang:master Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kirillbobyrev @rust-highfive @alexcrichton @bors @bstrie